sokol_gfx.h: add explicit depth / stencil formats #1124
Conversation
| case SG_PIXELFORMAT_RGBA32F: return DXGI_FORMAT_R32G32B32A32_FLOAT; | ||
| case SG_PIXELFORMAT_DEPTH: return DXGI_FORMAT_R32_TYPELESS; | ||
| case SG_PIXELFORMAT_DEPTH_STENCIL: return DXGI_FORMAT_R24G8_TYPELESS; | ||
| case SG_PIXELFORMAT_DEPTH24PLUS: return DXGI_FORMAT_R24G8_TYPELESS; |
There was a problem hiding this comment.
I couldn't find a DirectX format that mapped to a 24-bit depth buffer with no stencil - so SG_PIXELFORMAT_DEPTH24PLUS is equivalent to SG_PIXELFORMAT_DEPTH24PLUS_STENCIL8. Is this the correct approach, or should this format not be supported at all on DirectX?
| @@ -11693,6 +11768,10 @@ _SOKOL_PRIVATE MTLPixelFormat _sg_mtl_pixel_format(sg_pixel_format fmt) { | |||
| case SG_PIXELFORMAT_RGBA32F: return MTLPixelFormatRGBA32Float; | |||
| case SG_PIXELFORMAT_DEPTH: return MTLPixelFormatDepth32Float; | |||
| case SG_PIXELFORMAT_DEPTH_STENCIL: return MTLPixelFormatDepth32Float_Stencil8; | |||
| case SG_PIXELFORMAT_DEPTH24PLUS: return MTLPixelFormatDepth24Unorm_Stencil8; | |||
There was a problem hiding this comment.
This is similar to the problem on DirectX, there is no format that maps directly to just a 24-bit depth buffer.
kcbanner
force-pushed
the
depth_stencil_formats
branch
from
5255953
to
f24e71d
Compare
kcbanner
changed the title
|
Moving this into review now that the other formats have been added. See the comments above - I'm not sure how to handle |
|
Sorry, didn't get around yet to look into the PR. I'll try to make some time over the weekend :) I'll most like need to do a little research first for the other 3D backends. There's also always the option to split support for the different backends over multiple smaller PRs, might speed things up a bit :) |
Closes #1122.